Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sticky notes plugin #1006

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sticky notes plugin #1006

wants to merge 4 commits into from

Conversation

giomatfois62
Copy link

This is the first version of a sticky notes plugin for the panel.
Start creating notes by adding the plugin to the panel, clicking its button and selecting the "New Note" action.

  • The background and foreground color and the default font can be configured from the plugin configuration dialog. When changing the foreground color, the icons in the note frames are updated to match it for better visibility.

  • Each note allows to set its own custom font through a button in the top left of the note frame.

  • Each note has a title label showing date and time of creation.

  • It's possible to show/hide all notes and show/hide the window frame on the buttons on the notes.

An issue i could not resolve is that each note shows an entry on the taskbar, setting Qt::Tool in the window flags did not help (I'm pretty sure i tried this thing before and it used to work fine though).

@tsujan
Copy link
Member

tsujan commented Feb 23, 2019

I'll test it as soon as I find the time. I'll also take a look at the code but the real reviewer might be @palinek --- he sees things that I miss.

So, please be patient; it might take a while.

plugin-notes/notes.cpp Outdated Show resolved Hide resolved
plugin-notes/notes.cpp Outdated Show resolved Hide resolved
plugin-notes/notes.cpp Outdated Show resolved Hide resolved
plugin-notes/notes.cpp Outdated Show resolved Hide resolved
@giomatfois62
Copy link
Author

will do! thanks for the feedback palinek

plugin-notes/stickynote.h Outdated Show resolved Hide resolved
@shlyakpavel
Copy link
Member

Hello!
Unlike lxqt-panel itself, this plugin throws some compiler warnings.

stickynote.cpp:199:44: warning: unused parameter ‘event’
stickynote.cpp:215:15: warning: variable ‘geometry’ set but not used
notesconfiguration.cpp:50:53: warning: unused parameter ‘checked’

I personally don't think it's a big deal but it would be really nice if you fixed these.
Thanks for committing this! Have a nice day :)

@tsujan
Copy link
Member

tsujan commented Sep 3, 2019

Unlike lxqt-panel itself, this plugin throws some compiler warnings.

Compiled lxqt-panel today. Here, not only panel but all LXQt components throw compiler warnings. Nowadays, compilers have become too sensitive ;)

But the warnings about deprecated Qt methods need to be silenced, IMO.

@stefonarch
Copy link
Member

This is abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants